Re: [patch,v2 05/10] sd: use alloc_disk_node

From: Bart Van Assche
Date: Sat Nov 03 2012 - 12:37:30 EST


On 11/02/12 22:45, Jeff Moyer wrote:
Signed-off-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
---
drivers/scsi/sd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 12f6fdf..8deb915 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2714,7 +2714,7 @@ static int sd_probe(struct device *dev)
if (!sdkp)
goto out;

- gd = alloc_disk(SD_MINORS);
+ gd = alloc_disk_node(SD_MINORS, dev_to_node(dev));
if (!gd)
goto out_free;

shost->numa_node can be another NUMA node than dev_to_node(dev). Have you considered using shost->numa_node here ?

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/