Re: [PATCH] memcg: fix hotplugged memory zone oops

[Hugh Dickins]

On Fri, 2 Nov 2012, Michal Hocko wrote:
> 
> OK, it adds "an overhead" also when there is no hotadd going on but this
> is just one additional mem access&cmp&je so it shouldn't be noticable
> (lruvec->zone is used most of the time later so it not a pointless
> load).

I think so too.

> It is also easier to backport for stable.

Yes.

> But is there any reason to fix it later properly in the hotadd hook?

I don't know.  Not everybody liked it fixed this way: it's not
unreasonable to see this as a quick hack rather than the right fix.

I was expecting objectors to post alternative hotadd hook patches,
then we could compare and decide.  That didn't happen; but we can
certainly look to taking out these lines later if something we
agree is better comes along.  Not high on anyone's agenda, I think.

> 
> Anyway
> Acked-by: Michal Hocko <mhocko@xxxxxxx>

Thanks,
Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/