Re: [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

[Christoph Lameter]

On Sat, 3 Nov 2012, Shan Wei wrote:

> diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
> index 897ba6a..3aef5b2 100644
> --- a/net/batman-adv/main.h
> +++ b/net/batman-adv/main.h
> @@ -263,9 +263,7 @@ static inline bool batadv_has_timed_out(unsigned long timestamp,
>  static inline void batadv_add_counter(struct batadv_priv *bat_priv, size_t idx,
>  				      size_t count)
>  {
> -	int cpu = get_cpu();
> -	per_cpu_ptr(bat_priv->bat_counters, cpu)[idx] += count;
> -	put_cpu();
> +	this_cpu_add(bat_priv->bat_counters[idx], count);
>  }

Reviewed-by: Christoph Lameter <cl@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/