Re: [PATCH] [PATCH] x86: Don't clobber top of pt_regs in nested NMI

From: Steven Rostedt
Date: Fri Nov 02 2012 - 10:11:22 EST


On Fri, 2012-11-02 at 14:09 +0000, Jan Beulich wrote:

> >> subq $(5*8), %rsp
> >> + CFI_ADJUST_CFA_OFFSET 5*8
> >>
> >> CFI_DEF_CFA_OFFSET SS+8-RIP
> >> end_repeat_nmi:
> >>
> >
> > Is that second one even needed? Or will the CFI_DEF_CFA_OFFSET SS+8-RIP
> > fix it?
>
> Yes it will (as long as no intervening instructions get added; that's
> to say that I'd recommend removing the blank line to make clear
> that instruction and annotation belong together).

OK, will do.

Thanks!

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/