Re: regulator: tps51632: Seems current code doesn't properly supportdvfs_step_20mV case

[Laxman Dewangan]

On Thursday 01 November 2012 12:18 PM, Axel Lin wrote:
> Hi Laxman,
>
> While reading the tps51632 driver, I found there is a dvfs_step_20mV setting
> in platform data. But seems current code doesn't properly handle the case when
> dvfs_step_20mV is true.
>
> I guess if pdata->dvfs_step_20mV is true, we need:
>
> tps->desc.uV_step = TPS51632_VOLATGE_STEP_20mV;
> Fix TPS51632_VOLT_VSEL macro to support dvfs_step_20mV case.
> Also I'm wondering if either TPS51632_MAX_VSEL/TPS51632_MAX_VOLATGE or
> desc.n_voltages needs change for dvfs_step_20mV case.
>
> Oh, I don't have the datasheet, so my understanding might be wrong.

The steps for voltage and voltage base registers are the 10mV always.
The DVFS steps are used only when the steps (offsets) are provided 
through PWM.

So in DVFS case the  vout = voltage_base + pwm_offset* dvfs_steps.
And voltage_base = min_volt + sel * 10mV.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/