Re: [PATCH 6/9] kernel: padata : use this_cpu_ptr per-cpu helper

[Christoph Lameter]

On Wed, 31 Oct 2012, Shan Wei wrote:

> From: Shan Wei <davidshan@xxxxxxxxxxx>
>
>
> Signed-off-by: Shan Wei <davidshan@xxxxxxxxxxx>
> ---
>  kernel/padata.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/padata.c b/kernel/padata.c
> index 89fe3d1..70dffe8 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -204,7 +204,7 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
>  		goto out;
>  	}
>
> -	queue = per_cpu_ptr(pd->pqueue, smp_processor_id());
> +	queue = this_cpu_ptr(pd->pqueue);
>  	if (queue->cpu_index == next_queue->cpu_index) {

Its simpler to just remove the per_cpu op completely and change the if
statement to

	if (this_cpu_read(pd->pqueue->cpu_index) == next_queue->cpu_index))
{

..


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/