Re: [PATCH 2/2] dma: tegra20-apbdma: channel freeing correction

From: Laxman Dewangan
Date: Wed Oct 31 2012 - 10:50:07 EST


On Sunday 28 October 2012 07:47 PM, Dmitry Osipenko wrote:
Fixed channel "lock" after free.

Example: Channel 1 was allocated and prepared as slave_sg, used and freed. Now preparation of cyclic dma on channel 1 will fail with err "DMA
configuration conflict" because tdc->isr_handler still selected to handle_once_dma_done.

This happens because tegra_dma_abort_all() won't be called on channel freeing if pending list is empty.

Signed-off-by: Dmitry Osipenko<digetx@xxxxxxxxx>

Both patches looks good to me.

Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/