Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

From: Felipe Balbi
Date: Tue Oct 30 2012 - 14:54:23 EST


Hi,

On Tue, Oct 30, 2012 at 11:20:07AM -0700, Dmitry Torokhov wrote:
> On Tue, Oct 30, 2012 at 07:25:13PM +0200, Felipe Balbi wrote:
> > On Tue, Oct 30, 2012 at 03:58:21PM +0000, Mark Brown wrote:
> > >
> > > But then this comes round to the mindless code that ought to be factored
> > > out :) Only the more interesting cases that do something unusual really
> > > register here.
> >
> > fair enough. I see your point. Not saying I agree though, just that this
> > discussion has been flying for far too long, so feel free to provide
> > patches implementing what you're defending here ;-)
> >
> > Guess code will speak for itself. On way or another, we need OMAP keypad
> > driver working in mainline
>
> Are you saying that introducing pincrtl infrastructure actually _broke_
> the driver in mainline?

no dude, I'm saying we need pinctrl working for this driver because we
need to remove OMAP-specific MUX settings. One way or another, this has
to work.

--
balbi

Attachment: signature.asc
Description: Digital signature