Re: [PATCH] perf tools: Speed up the perf build time by simplifyingthe perf --version string generation
From: Ingo Molnar
Date: Tue Oct 30 2012 - 05:43:36 EST
* Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxx> wrote:
> Em Tue, Oct 30, 2012 at 09:46:00AM +0100, Ingo Molnar escreveu:
> > +++ b/tools/perf/util/PERF-VERSION-GEN
> > @@ -12,7 +12,7 @@ LF='
> > # First check if there is a .git to get the version from git describe
> > # otherwise try to get the version from the kernel makefile
> > if test -d ../../.git -o -f ../../.git &&
> > - VN=$(git describe --match 'v[0-9].[0-9]*' --abbrev=4 HEAD 2>/dev/null) &&
> > + VN=$(echo $(git tag --list "v[0-9].[0-9]*" | tail -1)"-g"$(git log -1 --abbrev=4 --pretty=format:"%h" HEAD) 2>/dev/null) &&
>
> [acme@sandy linux]$ make -j8 -C tools/perf/ O=/home/acme/git/build/perf install
> make: Entering directory `/home/git/linux/tools/perf'
> error: unknown option `list'
> usage: git tag [-a|-s|-u <key-id>] [-f] [-m <msg>|-F <file>] <tagname>
> [<head>]
>
> <SNIP>
>
> [acme@sandy linux]$ git --version
> git version 1.7.1
Does -l work?
Alternatively, please replace:
git tag --list "v[0-9].[0-9]*" | tail -1
with:
git tag | tail -1 | grep -E "v[0-9].[0-9]*"
which is just as fast.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/