Re: [PATCH 01/32] nohz: Move nohz load balancer selection into idlelogic

[Charles Wang]

calc_load_exit_idle depends on updated jiffies, so you shouldn't move 
this before tick_do_update_jiffies64.

And why should we do nohz_balance_enter_idle in tick_nohz_idle_exit? 
It's nohz_balance_exit_idle here.

Regards,
Charles

On 10/30/2012 04:27 AM, Steven Rostedt wrote:
ïsnippedï
> @@ -573,7 +573,6 @@ static void tick_nohz_restart_sched_tick(struct 
tick_sched *ts, ktime_t now)
>  	tick_do_update_jiffies64(now);
>  	update_cpu_load_nohz();
>
> -	calc_load_exit_idle();
>  	touch_softlockup_watchdog();
>  	/*
>  	 * Cancel the scheduled timer and restore the tick
> @@ -628,6 +627,8 @@ void tick_nohz_idle_exit(void)
>  		tick_nohz_stop_idle(cpu, now);
>
>  	if (ts->tick_stopped) {
> +		nohz_balance_enter_idle(cpu);
> +		calc_load_exit_idle();
>  		tick_nohz_restart_sched_tick(ts, now);
>  		tick_nohz_account_idle_ticks(ts);
>  	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/