RE: [PATCH] hrtimer: Printing timer info when hitting BUG_ON()

[Liu, Chuansheng]

> -----Original Message-----
> From: Peter Zijlstra [mailto:a.p.zijlstra@xxxxxxxxx]
> Sent: Monday, October 29, 2012 5:06 PM
> To: Liu, Chuansheng
> Cc: tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Li, Fei;
> yanmin_zhang@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] hrtimer: Printing timer info when hitting BUG_ON()
> 
> On Mon, 2012-10-29 at 19:02 +0800, Chuansheng Liu wrote:
> > +/*
> > + * dump_hrtimer_callinfo - print hrtimer information including:
> > + * state, callback function, pid and start_site.
> > +*/
> > +static void dump_hrtimer_callinfo(struct hrtimer *timer)
> > +{
> > +
> > +       char symname[KSYM_NAME_LEN];
> > +
> > +       if (lookup_symbol_name((unsigned long)(timer->function),
> symname) < 0) {
> > +               pr_err("timer info: state/%lx, func/%pK\n",
> > +                       timer->state, timer->function);
> > +       } else {
> > +               pr_err("timer info: state/%lx, func/%s",
> > +                       timer->state, symname);
> > +       }
> > +
> > +#ifdef CONFIG_TIMER_STATS
> > +       if (lookup_symbol_name((unsigned long)(timer->start_site),
> > +                                               symname) < 0) {
> > +               pr_err("timer stats: pid/%d(%s), site/%pK\n",
> > +                       timer->start_pid, timer->start_comm,
> timer->start_site);
> > +       } else {
> > +               pr_err("timer stats: pid/%d(%s), site/%s\n",
> > +                       timer->start_pid, timer->start_comm,
> symname);
> > +       }
> > +#endif
> > +}
> 
> What's wrong with %pf ?
Thanks Peter's help and pointing out, patch V2 has been sent.
This patch helps us to find out the root cause quickly.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/