Re: [PATCH 5/5] fat: add mutex lock to fat_build_inode

From: Andrew Morton
Date: Mon Oct 29 2012 - 19:49:29 EST


On Sun, 28 Oct 2012 10:53:43 +0900
Namjae Jeon <linkinjeon@xxxxxxxxx> wrote:

> From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
>
> fat_nfs_get_inode does not hold i_mutex of parent directory.So add
> lock to fat_build_inode.

Well.. why? Presumably this patch fixes some race. A good
description of that race would be useful - partly because others may
then be able to suggest alternative ways of fixing that bug.

I'll merge these patches for some testing.

I did merge these patches three weekes ago:

fat-modify-nfs-mount-option.patch
fat-exportfs-rebuild-inode-if-ilookup-fails.patch
fat-exportfs-rebuild-inode-if-ilookup-fails-fix.patch
fat-exportfs-rebuild-directory-inode-if-fat_dget-fails.patch
documentation-update-nfs-option-in-filesystem-vfattxt.patch

But I have no record of Bruce or Ogawa having reviewed/acked them?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/