Re: [PATCH 1/2] drivers/net/ethernet/nxp/lpc_eth.c: Callmdiobus_unregister before mdiobus_free

From: Alexandre Pereira da Silva
Date: Mon Oct 29 2012 - 07:58:03 EST


On Sun, Oct 28, 2012 at 2:12 PM, Peter Senna Tschudin
<peter.senna@xxxxxxxxx> wrote:
> Based on commit b27393aecf66199f5ddad37c302d3e0cfadbe6c0
>
> Calling mdiobus_free without calling mdiobus_unregister causes
> BUG_ON(). This patch fixes the issue.
>
> The semantic patch that found this issue(http://coccinelle.lip6.fr/):
> // <smpl>
> @@
> expression E;
> @@
> ... when != mdiobus_unregister(E);
>
> + mdiobus_unregister(E);
> mdiobus_free(E);
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx>
> ---

Tested-by: Alexandre Pereira da Silva <aletes.xgr@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/