Re: [BUG] perf parser: does not support arbitrary new sysfs events

From: Stephane Eranian
Date: Mon Oct 29 2012 - 05:43:50 EST


On Mon, Oct 29, 2012 at 2:50 AM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> Stephane Eranian <eranian@xxxxxxxxxx> writes:
>
>> Hi,
>>
>> The latest round of perf parser changes broke my PEBS-LL patch series
>> (at the last minute). For PEBS-LL, I need to add to generic events but I want
>> to keep them PMU specific. As such, they need to live in the sysfs events
>> subdir: /sys/devices/cpu/events/mem-loads, sys/devices/cpu/events/mem-stores.
>>
>> Given your latest rounds of sysfs event changes, I had to modify my kernel
>> patches to fit those two new events within your perf_pmu_events_attr tables.
>>
>> But now, when I try to do:
>>
>> $ perf record -e cpu/mem-loads/ ....
>
> - is not supported in an event name. I fixed this in my patchkit
>
Yes, this was indeed the problem. Glad you tracked it down.

We need this patch ASAP.

> Yes the sysfs stuff in general is quite fragile.
>
I would say complicated rather than fragile.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/