Re: [PATCH] Regulator: core: Unregister when gpio request fails.

From: Mark Brown
Date: Sun Oct 28 2012 - 14:15:45 EST


On Sun, Oct 28, 2012 at 04:01:11PM +0100, Andrew Lunn wrote:
> If the gpio_request_one() fails, or returns EPROBE_DEFER, the
> regulator must be device_unregister()ed. When this is not done,
> there are WARNING: from sysfs:
>
> WARNING: at fs/sysfs/file.c:343 sysfs_open_file+0x238/0x268()

Applied, thanks. Please remember to submit patches with subject lines
that match the subsystem. Also

> + goto wash;

that's a bit too cute and is going to hurt maintainability, meaningful
names are helpful when you get a bunch of things (eg, "clean_gpio").

Attachment: signature.asc
Description: Digital signature