Re: [PATCH 08/16] i2c: Convert dev_printk(KERN_<LEVEL> todev_<level>(

From: Jean Delvare
Date: Sun Oct 28 2012 - 07:52:07 EST


Hi Joe,

On Sun, 28 Oct 2012 01:05:46 -0700, Joe Perches wrote:
> dev_<level> calls take less code than dev_printk(KERN_<LEVEL>
> and reducing object size is good.
> Coalesce formats for easier grep.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-piix4.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
> index 8bbd6ec..f7216ed 100644
> --- a/drivers/i2c/busses/i2c-piix4.c
> +++ b/drivers/i2c/busses/i2c-piix4.c
> @@ -204,9 +204,8 @@ static int __devinit piix4_setup(struct pci_dev *PIIX4_dev,
> */
> pci_write_config_byte(PIIX4_dev, SMBHSTCFG,
> temp | 1);
> - dev_printk(KERN_NOTICE, &PIIX4_dev->dev,
> - "WARNING: SMBus interface has been "
> - "FORCEFULLY ENABLED!\n");
> + dev_notice(&PIIX4_dev->dev,
> + "WARNING: SMBus interface has been FORCEFULLY ENABLED!\n");
> } else {
> dev_err(&PIIX4_dev->dev,
> "Host SMBus controller not enabled!\n");

Applied, thanks.

--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/