Re: [PATCH 1/5] debugfs: pass NULL as the last parameter ofdebugfs_print_regs32()

From: Greg KH
Date: Sat Oct 27 2012 - 11:06:20 EST


On Sat, Oct 27, 2012 at 04:05:25PM +0800, Yan Hong wrote:
> If 'prefix' is not used, pass NULL instead of empty string as the
> last parameter of debugfs_print_regs32().
>
> Cc: Alessandro Rubini <rubini@xxxxxxxxx>
>
> Signed-off-by: Yan Hong <clouds.yan@xxxxxxxxx>
> ---
>
> This function is only used (twice) by the author of it, and the
> 'prefix' feature is never used. But it's a well-documented debugfs
> API. It's added one year ago and appeared in many documents. I still
> prefer to let this API stay unchanged and treat the empty string as
> typo.

What "documents" did this appear in? If the parameter isn't being used,
please, just delete it.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/