Re: mmotm 2012-10-24-17-15 uploaded (uml)

From: Jiri Slaby
Date: Sat Oct 27 2012 - 08:13:01 EST


This is a multi-part message in MIME format.On 10/25/2012 04:48 AM, Stephen Rothwell wrote:
> Hi Randy,
>
> On Wed, 24 Oct 2012 18:17:59 -0700 Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
>>
>> uml on x86_64 defconfig:
>>
>> arch/um/drivers/chan_kern.c: In function 'tty_receive_char':
>> arch/um/drivers/chan_kern.c:89:42: error: 'struct tty_struct' has no member named 'raw'

Hmm, that code looks doing weird stuff. This patch should fix it. But
I'm not sure why it was there at all, as n_tty should take care of the
raw case perfectly right away. I cannot find any clues in the git log as
to why it was added at all. It's there like since ever.

Could anybody with working UML (I'm unable to run UML ATM, it crashes
heavily during the bootup -- after terminals are shown) check whether
the patch actually works?

thanks,
--
js
suse labs