Re: [PATCH 2/3] PCI: correctly detect ACPI PCI host bridge objects

From: Yinghai Lu
Date: Fri Oct 26 2012 - 14:13:43 EST


On Fri, Oct 26, 2012 at 2:10 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> On Thu, Oct 18, 2012 at 2:50 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>>
>> +static const struct acpi_device_id root_device_ids[] = {
>> + {"PNP0A03", 0},
>> + {"PNP0A08", 0},
>
> Why do we need PNP0A08 here?
>
> Per the PCI Firmware Spec, sec 4.1.5, PNP0A08 identifies a PCI Express
> or a PCI-X Mode 2 host bridge, and such a device is required to
> include PNP0A03 in _CID. Therefore, it should be sufficient to look
> only for PNP0A03.

good, I removed that line and updated for-pci-split-pci-root-hp-2 branch.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/