Re: [PATCH 2/3] debugfs: code clean and refactor

From: Greg KH
Date: Fri Oct 26 2012 - 14:12:52 EST


On Sat, Oct 27, 2012 at 01:55:43AM +0800, Yan Hong wrote:
> debug_fill_super():
> return directly if failed to allocate debugfs_fs_info.
>
> __create_file():
> remove redundant initialization.
>
> __debugfs_remove():
> remove redundant check.
> debugfs_positive() already checked dentry->inode is not NULL.

You did 3 different things, so that should be at least 3 different
patches.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/