Re: [PATCH V2 2/4] arm: mvebu: adding SATA support: dt binding forArmada 370/XP

[Gregory CLEMENT]

On 10/26/2012 03:34 PM, Andrew Lunn wrote:
> On Fri, Oct 26, 2012 at 09:31:54AM -0400, Jason Cooper wrote:
>> On Fri, Oct 26, 2012 at 02:30:47PM +0200, Gregory CLEMENT wrote:
>>> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
>>> Signed-off-by: Lior Amsalem <alior@xxxxxxxxxxx>
>>> ---
>>>  arch/arm/boot/dts/armada-370-xp.dtsi |    9 +++++++++
>>>  1 file changed, 9 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
>>> index 94b4b9e..a911f7a 100644
>>> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
>>> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
>>> @@ -69,6 +69,15 @@
>>>  			compatible = "marvell,armada-addr-decoding-controller";
>>>  			reg = <0xd0020000 0x258>;
>>>  		};
>>> +
>>> +		sata@d00a0000 {
>>> +                        compatible = "marvell,orion-sata";
>>> +                        reg = <0xd00a0000 0x2400>;
>>> +                        interrupts = <55>;
>>> +			clocks = <&coreclk 0>;
>>
>> nit. whitespace?
> 
> [Don't shoot the messenger]
> 
> How about extending checkpatch to check for this? I guess its just
> spaces which should be tabs.

No it is the opposite in fact! On this line it's tabs: 3 tabs of 8
whitespace, so the line start at 24. But as there is a '+', the first
tab is only 7, so it is still start at 24. Whereas for the other lines
it's 24 white spaces, so with the '+' it starts at 25. That's why I
didn't notice it, and if you apply the patch all is fine.

Now, about white spaces vs tab, I don't know what is the rule for .dts
file.


Gregory
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/