Re: PCIe IO space support on Tilera GX: Is there any one who canconfirm my modification to fix it is OK?

[Bjorn Helgaas]

On Fri, Oct 26, 2012 at 3:01 AM, Cyberman Wu <cypher.w@xxxxxxxxx> wrote:
> We're not using 3.6.x, we're using is from MDE-4.1.0 from Tilera and
> it patch 3.0.38.

That's fine, but you sent the email to the linux-pci and linux-kernel
lists, and on those lists, we're only concerned with the upstream
Linux kernels, e.g., 3.6.  If you need support for MDE-4.1.0, you need
to talk to whoever supplies that, because we have no idea what it is.

> For mvsas, it seems do think 0 I/O address invalied.

That's a driver bug.  Zero is a perfectly valid I/O address.  On many
systems it's not usable because of platform restrictions, but the
driver has no way to know about those restrictions, and the driver
should still work on the platforms where zero *is* usable.

> When we using MDE-4.0.0 it don't support I/O space, I just bypass
> these check since after
> investigate all code of mvsas it seems that I/O space map to BAR 2 is
> not really used.

If the driver doesn't need I/O space, it'd be a lot simpler to just
change it to use pci_enable_device_mem(), which indicates that we
don't need to enable I/O BARs, and strip out the code that checks
whether the I/O BARs are valid.  Then you wouldn't need to mess with
adding I/O space support in your platform.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/