Re: [PATCH 02/16 v2] f2fs: add on-disk layout

[Arnd Bergmann]

On Friday 26 October 2012, Jaegeuk Kim wrote:

> > > +
> > > +#define F2FS_ROOT_INO(sbi)	(sbi->root_ino_num)
> > > +#define F2FS_NODE_INO(sbi)	(sbi->node_ino_num)
> > > +#define F2FS_META_INO(sbi)	(sbi->meta_ino_num)
> > > +
> > > +#define GFP_F2FS_MOVABLE	(__GFP_WAIT | __GFP_IO | __GFP_ZERO)
> > > +
> > > +#define MAX_ACTIVE_LOGS	16
> > > +#define MAX_ACTIVE_NODE_LOGS	8
> > > +#define MAX_ACTIVE_DATA_LOGS	8
> > 
> > I think that it makes sense to comment the reasons of such limitations
> > in MAX_ACTIVE_LOGS, MAX_ACTIVE_NODE_LOGS, MAX_ACTIVE_DATA_LOGS.
> 
> The maximum number of logs is suggested by arnd before.
> As I understood, why he suggested such a quite large number is for further
> optimization of multiple logs without any on-disk layout changes.
> And, I think it is quite enough.

I agree. I think Vyacheslav was just asking you to add a comment
explaining how we got to these numbers, like

/*
 * The file format supports up to 16 active logs, which should be
 * more than enough for future optimizations. The implementation
 * currently uses no more than 6 logs.
 * Half the logs are used for nodes, the other half are used for data.
 */


	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/