Re: [PATCH] net: usb: Fix memory leak on Tx data path

[Oliver Neukum]

On Thursday 25 October 2012 21:17:54 Hemant Kumar wrote:
> Driver anchors the tx urbs and defers the urb submission if
> a transmit request comes when the interface is suspended.
> Anchoring urb increments the urb reference count. These
> deferred urbs are later accessed by calling usb_get_from_anchor()
> for submission during interface resume. usb_get_from_anchor()
> unanchors the urb but urb reference count remains same.
> This causes the urb reference count to remain non-zero
> after usb_free_urb() gets called and urb never gets freed.
> Hence call usb_put_urb() after anchoring the urb to properly
> balance the reference count for these deferred urbs. Also,
> unanchor these deferred urbs during disconnect, to free them
> up.

Good catch. This needs to go into stable, too.
> 
> Signed-off-by: Hemant Kumar <hemantk@xxxxxxxxxxxxxx>
Acked-by: Oliver Neukum <oneukum@xxxxxxx>

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/