Re: [PATCH v3 2/6] Add the main bulk of core driver for SI476x code

From: Mark Brown
Date: Thu Oct 25 2012 - 15:45:19 EST


On Tue, Oct 23, 2012 at 11:44:28AM -0700, Andrey Smirnov wrote:

> + core->regmap = devm_regmap_init_si476x(core);
> + if (IS_ERR(core->regmap)) {

This really makes little sense to me, why are you doing this? Does the
device *really* layer a byte stream on top of I2C for sending messages
that look like marshalled register reads and writes?

Attachment: signature.asc
Description: Digital signature