Re: [PATCH] fs: xattr: rewrite simple_xattr_set()

From: Aristeu Rozanski
Date: Thu Oct 25 2012 - 13:54:09 EST


On Thu, Oct 25, 2012 at 10:33:26AM -0700, Tejun Heo wrote:
> On Thu, Oct 25, 2012 at 11:26:14AM -0400, Aristeu Rozanski wrote:
> > - return err;
> >
> > + return 1;
> > +}
>
> So, it returns 0 on success and 1 on failure, which in itself isn't a
> particularly good idea.

you mean it should return -ENODATA instead?

--
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/