Re: [PATCH 1/1] freezer: exec should clear PF_NOFREEZE along withPF_KTHREAD

From: Tejun Heo
Date: Thu Oct 25 2012 - 13:20:12 EST


On Thu, Oct 25, 2012 at 07:12:56PM +0200, Oleg Nesterov wrote:
> flush_old_exec() clears PF_KTHREAD but forgets about PF_NOFREEZE.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Probably needs Cc: stable.

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

How should this be routed? -mm? Andrew, can you please pick this up?

Thanks.

> ---
> fs/exec.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/exec.c b/fs/exec.c
> index 8b9011b..0039055 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -1083,7 +1083,8 @@ int flush_old_exec(struct linux_binprm * bprm)
> bprm->mm = NULL; /* We're using it now */
>
> set_fs(USER_DS);
> - current->flags &= ~(PF_RANDOMIZE | PF_FORKNOEXEC | PF_KTHREAD);
> + current->flags &=
> + ~(PF_RANDOMIZE | PF_FORKNOEXEC | PF_KTHREAD | PF_NOFREEZE);
> flush_thread();
> current->personality &= ~bprm->per_clear;
>
> --
> 1.5.5.1
>
>

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/