Re: [PATCH 1/2] openrisc: move sys_clone's stack determination tocopy_thread

From: Jonas Bonn
Date: Thu Oct 25 2012 - 12:16:13 EST


On Thu, 2012-10-25 at 16:55 +0100, Al Viro wrote:
> On Thu, Oct 25, 2012 at 05:46:38PM +0200, Jonas Bonn wrote:
> > + else
> > + userregs->sp = regs->sp; /* fork/clone */
>
> What for? userregs->sp will be equal to regs->sp at that point, unless
> your compiler is very badly broken. You've copied *regs to *userregs
> wholesale, just above that if...

So true... that makes it even simpler. Will resend.
/Jonas

Attachment: signature.asc
Description: This is a digitally signed message part