Re: [RFC] Support volatile range for anon vma

From: Christoph Lameter
Date: Thu Oct 25 2012 - 11:19:20 EST


On Thu, 25 Oct 2012, Minchan Kim wrote:

> #endif
> + /*
> + * True if page in this vma is reclaimed.

What does that mean? All pages in the vma have been cleared out?

> + TTU_IGNORE_VOLATILE = (1 << 11),/* ignore volatile */
> };
> #define TTU_ACTION(x) ((x) & TTU_ACTION_MASK)
>
> int try_to_unmap(struct page *, enum ttu_flags flags);
> int try_to_unmap_one(struct page *, struct vm_area_struct *,
> - unsigned long address, enum ttu_flags flags);
> + unsigned long address, enum ttu_flags flags,
> + bool *is_volatile);

You already pass a vma pointer in. Why do you need to pass a
volatile flag in? Looks like unecessary churn.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/