Re: [PATCH v3] Add support for AMD64 EDAC on multiple PCI domains

[Ingo Molnar]

* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Thu, Oct 25, 2012 at 04:32:52PM +0800, Daniel J Blueman wrote:
> > The AMD Northbridge initialisation code and EDAC assume the Northbridge IDs
> > are contiguous, which no longer holds on federated systems with multiple
> > HyperTransport fabrics and multiple PCI domains, eg on Numascale's
> > Numaconnect systems with NumaChip.
> > 
> > Address this assumption by searching the Northbridge ID array, rather than
> > directly indexing it, using the upper bits for the PCI domain.
> > 
> > RFC->v2: Correct array initialisation
> > v2->v3: Add Boris's neater linked list approach
> > 
> > Todo:
> > 1. fix kobject/sysfs oops (see http://quora.org/2012/16-server-boot.txt later)
> > 2. reorder amd64_edac.c or add amd64_per_family_init/pci_get_related_function
> >    forward declarations, based on feedback
> > 
> > Signed-off-by: Daniel J Blueman <daniel@xxxxxxxxxxxxxxxxxx>
> 
> This patch contains code from both of us and thus needs both our SOBs:
> 
> Signed-off-by: Borislav Petkov <bp@xxxxxxxxx>

No, SOBs are to document patch forwarding. Co-authorship can be 
expressed a number of ways, such as:

Based-on-patch-from: Borislav Petkov <bp@xxxxxxxxx>

and/or by adding you as a copyright holder to one of the files.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/