Re: [PATCH 02/26] pstore: add flags

From: Tatulea, Dragos
Date: Thu Oct 25 2012 - 07:25:38 EST


On Tue, Oct 23, 2012 at 7:57 PM, Luck, Tony <tony.luck@xxxxxxxxx> wrote:
>> I wonder if the default should be to not show headers, and to add this
>> flag to the backends that want the pstore-added header. I think the
>> more common case going forward will to be without headers since
>> backends should arguably storing metadata themselves.
>
> Perhaps just add the headings when pstore breaks a dump into
> pieces because of a back-end size limitation. I.e. if there is only
> one piece, then no headings. If there are two or more, include
> a heading to aid with putting the pieces together later.
>
But how do you determine the kmsg data size without doing a
kmsg_dump_get_buffer beforehand?

Thanks,
Dragos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/