Re: [bug] perf_event_intel_uncore.c build warnings on allnoconfig

[Ingo Molnar]

* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> Ingo Molnar <mingo@xxxxxxxxxx> writes:
> 
> > FYI, on a 'make allnoconfig' x86_64 kernel I get a stream of 
> > warnings:
> >
> >  arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ???snbep_uncore_pci_disable_box???:
> >  arch/x86/kernel/cpu/perf_event_intel_uncore.c:124:9: warning: ???config??? is used uninitialized in this function [-Wuninitialized]
> >  arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ???snbep_uncore_pci_enable_box???:
> >  arch/x86/kernel/cpu/perf_event_intel_uncore.c:135:9: warning: ???config??? is used uninitialized in this function [-Wuninitialized]
> >  arch/x86/kernel/cpu/perf_event_intel_uncore.c: In function ???snbep_uncore_pci_read_counter???:
> >  arch/x86/kernel/cpu/perf_event_intel_uncore.c:164:2: warning: ???count??? is used uninitialized in this function [-Wuninitialized]
> >
> > Please fix this - if pci_read_config_dword() returns an error it 
> > should be handled - that will fix these warnings as well.
> 
> Can it even return an error on x86? I don't know of any 
> existing mechanism for this, short of a machine check.

It will return an error on !CONFIG_PCI at least.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/