Re: [stable 2.6.32..2.6.34] x86, ioapic: initializenr_ioapic_registers early in mp_register_ioapic()

From: Jonathan Nieder
Date: Wed Oct 24 2012 - 15:18:25 EST


Suresh Siddha wrote:

> commit 4b6b19a1c7302477653d799a53d48063dd53d555

Oh, yuck. If that commit had changed io_apic_get_redir_entries()'s
name, it would have avoided some trouble. Thanks for pointing it out.

> Wanted to keep the changes as minimal as possible.

I don't see how this is conceptually simpler than a version that also
removes the nr_ioapic_registers calculation in enable_IO_APIC().

Either way, please do mention 4b6b19a1c730 in the commit message so
others looking at the patch can see the off-by-one that is being
narrowly avoided. Thanks for your help and patience.

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/