Re: [PATCH 4/7] cgroup_freezer: don't stall transition to FROZEN forPF_NOFREEZE or PF_FREEZER_SKIP tasks

From: Tejun Heo
Date: Wed Oct 24 2012 - 15:06:54 EST


Hello, Oleg.

On Tue, Oct 23, 2012 at 05:55:33PM +0200, Oleg Nesterov wrote:
> > Ooh, ouch, definitely. We should clear that. Can you please make a
> > patch?
>
> Sure... but what do you think is better?
>
> I'd prefer to simply clear PF_NOFREEZE (without set_freezable), but
> obviously this doesn't look exactly right from cgroup_freezer pov.

I don't think it matters all that much. It's a pretty special case.
Maybe define PF_CLEAR_ON_EXEC_MASK or something and just include
PF_NOFREEZE in it?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/