Re: [PATCH 04/21] procfs: drop vmtruncate

From: Marco Stornelli
Date: Wed Oct 24 2012 - 12:09:24 EST


Il 24/10/2012 17:12, Christoph Hellwig ha scritto:
On Sat, Oct 20, 2012 at 02:17:33PM +0200, Marco Stornelli wrote:
Removed vmtruncate

Signed-off-by: Marco Stornelli <marco.stornelli@xxxxxxxxx>

As Al pointed out we probably shouldn't even allow truncate on procfs.
Can look into refusing it instead, please?



Mmmm...for example the command "truncate --size=100 config.gz" is a nop, so it seems to me it makes no sense to support the size change, but I don't know if there are other use cases. However, should we return EPERM in case of size change checking it before inode_change_ok()?

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/