Re: [PATCH -mm] procfs: add VmFlags field in smaps output v3

From: Cyrill Gorcunov
Date: Wed Oct 24 2012 - 08:56:35 EST


On Wed, Oct 24, 2012 at 11:47:14PM +1100, Stephen Rothwell wrote:
> Hi Cyrill,
>
> On Wed, 24 Oct 2012 16:27:30 +0400 Cyrill Gorcunov <gorcunov@xxxxxxxxxx> wrote:
> >
> > +static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)
> > +{
> > + /*
> > + * Don't forget to update Documentation/ on changes.
> > + */
> > + static const char mnemonics[BITS_PER_LONG][2] = {
> > + /*
> > + * In case if we meet a flag we don't know about.
> > + */
> > + [0 ... (BITS_PER_LONG-1)] = { "??" },
>
> Sorry to be picky, but the braces above are unnecessary,

Thanks, Stephen! I'm deferring update for a while, ok? If there will
be no more comments i'll drop the braces a bit later.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/