Re: [patch/rfc/rft] sd: allocate request_queue on device's localnuma node

From: Jens Axboe
Date: Tue Oct 23 2012 - 13:58:48 EST


On 2012-10-23 19:42, Bart Van Assche wrote:
> On 10/23/12 18:52, Jeff Moyer wrote:
>> Bart Van Assche <bvanassche@xxxxxxx> writes:
>>> Please keep in mind that a
>>> single PCIe bus may have a minimal distance to more than one NUMA
>>> node. See e.g. the diagram at the top of page 8 in
>>> http://bizsupport1.austin.hp.com/bc/docs/support/SupportManual/c03261871/c03261871.pdf
>>> for a system diagram of a NUMA system where each PCIe bus has a
>>> minimal distance to two different NUMA nodes.
>>
>> That's an interesting configuration. I wonder what the numa_node sysfs
>> file contains for such systems--do you know? I'm not sure how we could
>> allow this to be user-controlled at probe time. Did you have a specific
>> mechanism in mind? Module parameters? Something else?
>
> As far as I can see in drivers/pci/pci-sysfs.c the numa_node sysfs
> attribute contains a single number, even for a topology like the one
> described above.

This is an artifact of how ACPI works, it's not possible to have it be a
mask of nodes. But obviously that is how most intel based systems from
the last few years works, so the kernel parts should be updated to at
least allow it to be a mask. How to get this information is a separate
problem.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/