Re: [PATCH] vlan: set sysfs device_type to 'vlan'

From: David Miller
Date: Tue Oct 23 2012 - 13:11:32 EST


From: Kay Sievers <kay@xxxxxxxx>
Date: Tue, 23 Oct 2012 12:34:11 +0200

> On Tue, Oct 23, 2012 at 8:36 AM, David Miller <davem@xxxxxxxxxxxxx> wrote:
>> From: Doug Goldstein <cardoe@xxxxxxxxxx>
>> Date: Mon, 22 Oct 2012 00:53:57 -0500
>>
>>> Sets the sysfs device_type to 'vlan' for udev. This makes it easier for
>>> applications that query network information via udev to identify vlans
>>> instead of using strrchr().
>>>
>>> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
>>
>> You're extremely misguided. This change, in fact, makes it ten times
>> harder for such applications to query such devices.
>
> That makes not much sense, really. Every new interface would fall into
> that category. At least I can't see any mis-guidance here. The other
> devtypes for the major netif types are not that much older.

Only interfaces which provide a facility available in another way
fall into this category.

Thanks for the scarecrow, but no.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/