Re: [PATCH 02/26] pstore: add flags

[Kees Cook]

On Tue, Oct 23, 2012 at 6:48 AM, Irina Tirdea <irina.tirdea@xxxxxxxxx> wrote:
> From: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>
> Let the back end tweak pstore behaviour.  Flags added are:
>
>         PSTORE_NO_HEADINGS
>
>                 Omit pstore heading lines from dumped data

I wonder if the default should be to not show headers, and to add this
flag to the backends that want the pstore-added header. I think the
more common case going forward will to be without headers since
backends should arguably storing metadata themselves.

Thoughts?

>         PSTORE_MAX_KMSG_BYTES
>
>                 Default kmsg_bytes to ULONG_MAX
>
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>

Either way, this patch looks logically fine to me.

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/