Re: [PATCH 1/2]staging: "ehci-w90x900" Fix typos.

From: Alan Stern
Date: Tue Oct 23 2012 - 10:12:55 EST


On Mon, 22 Oct 2012, Justin P. Mattock wrote:

> From: "Justin P. Mattock" <justinmattock@xxxxxxxxx>
>
> Signed-off-by: Justin P. Mattock <justinmattock@xxxxxxxxx>
>
> ---
>
> The below patch fixes a typo in staging: "ehci-w90x900"

What does ehci-w90x900 have to do with staging?

> drivers/usb/host/ehci-w90x900.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-w90x900.c b/drivers/usb/host/ehci-w90x900.c
> index ec59808..a9c28a0 100644
> --- a/drivers/usb/host/ehci-w90x900.c
> +++ b/drivers/usb/host/ehci-w90x900.c
> @@ -13,7 +13,7 @@
>
> #include <linux/platform_device.h>
>
> -/*ebable phy0 and phy1 for w90p910*/
> +/*enable phy0 and phy1 for w90p910*/

Why bother to correct the spelling without also correcting the missing
whitespace?

> #define ENPHY (0x01<<8)
> #define PHY0_CTR (0xA4)
> #define PHY1_CTR (0xA8)

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/