Re: [PATCH 14/34] perf, x86: Avoid checkpointed counters causingexcessive TSX aborts

[Peter Zijlstra]

On Thu, 2012-10-18 at 16:19 -0700, Andi Kleen wrote:
> +       /* XXX move somewhere else. */
> +       if (cpuc->events[2] && (cpuc->events[2]->hw.config & HSW_INTX_CHECKPOINTED))
> +               status |= (1ULL << 2); 

A comment explaining about those 'spurious' PMIs would go along with
this nicely, no? I'm very sure I'd keep having to look up the commit
introducing this to figure out wtf its for.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/