Re: [PATCH 06/19] x86, mm: setup page table in top-down

[Stefano Stabellini]

On Mon, 22 Oct 2012, Yinghai Lu wrote:
> On Mon, Oct 22, 2012 at 11:17 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> > On Mon, Oct 22, 2012 at 6:19 AM, Stefano Stabellini
> 
> > How about put sth:
> > ---
> > Xen mmu requires pages from this function should be directly mapped already.
> > ---
> >
> > or you can introduce some doc tag specially that we can out those
> > assumption easily?
> 
> I add
> 
> /* Xen requires pages from this function should be directly mapped already */
> 
> in   [PATCH] x86, mm: Add alloc_low_pages(num)
> 
> hope you are happy with that.
> 

It is not bad, but let's just fix the English a bit and give more
context:

/* Pages returned by this function are already directly mapped.
 *
 * Changing that is likely to break Xen, see commit
 * 279b706bf800b5967037f492dbe4fc5081ad5d0f for more information on the
 * subject.
 */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/