Re: [PATCH 06/19] x86, mm: setup page table in top-down

[Yinghai Lu]

On Mon, Oct 22, 2012 at 6:19 AM, Stefano Stabellini
<stefano.stabellini@xxxxxxxxxxxxx> wrote:

>> > The series is starting to get in good shape!
>> > I tested it on a 2G and an 8G VM and it seems to be working fine.
>>
>> domU on 32bit and 64bit?
> domU 64bit

Can you test domU 32bit too?
I did not test that, and looks like Jacob only test 64 bit domU too.

>> alloc_low_page() is used in arch/x86/mm/init*.c. How come it becomes
>> interface to
>> other subsystem?
>
> I chose the wrong words.
>
> I meant that always allocating pages from areas that are already mapped,
> will become an assumption for other x86 subsystems like Xen.
> One shouldn't just go ahead and change this assumption without changing
> the subsystems too.

that looks like xen's problem, it should let us know what kind of
assumption that is there for xen.
We can not go deep to xen find those.

> I just want to make sure that 3 years from now, when somebody comes up
> with a new great idea to improve the intial pagetable allocation, he
> doesn't forget that changing alloc_low_page might break other subsystems.
>
> So I think that a comment is required here and should explicitly
> mention why it is important that alloc_low_page returns a mapped page.

How about put sth:
---
Xen mmu requires pages from this function should be directly mapped already.
---

or you can introduce some doc tag specially that we can out those
assumption easily?

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/