Re: [PATCH 1/6] perf, x86: Basic Haswell LBR call stack support

[Andi Kleen]

On Mon, Oct 22, 2012 at 12:35:38PM +0200, Peter Zijlstra wrote:
> On Mon, 2012-10-22 at 14:11 +0800, Yan, Zheng wrote:
> > --- a/include/uapi/linux/perf_event.h
> > +++ b/include/uapi/linux/perf_event.h
> > @@ -160,8 +160,9 @@ enum perf_branch_sample_type {
> >         PERF_SAMPLE_BRANCH_ABORT        = 1U << 7, /* transaction aborts */
> >         PERF_SAMPLE_BRANCH_INTX         = 1U << 8, /* in transaction (flag) */
> >         PERF_SAMPLE_BRANCH_NOTX         = 1U << 9, /* not in transaction (flag) */
> > +       PERF_SAMPLE_BRANCH_CALL_STACK   = 1U << 10, /* call stack */
> >  
> > -       PERF_SAMPLE_BRANCH_MAX          = 1U << 10, /* non-ABI */
> > +       PERF_SAMPLE_BRANCH_MAX          = 1U << 11, /* non-ABI */
> >  }; 
> 
> You add an ABI sample type without mentioning it in your changelog.. I
> think I'll stop reading here.

This is a LBR sample type, not a normal sample type.
I think this is only for when LBR mode is enabled in parallel.
Probably doesn't even make sense. 

For this feature no ABI changes should be needed because it can
be just reported like any other callgraph with the existing callstack
sample type. 

So this could be removed.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/