Re: RFC: sign the modules at install time

[Linus Torvalds]

On Thu, Oct 18, 2012 at 6:23 PM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
>
> Smerged them together: no point moving the x509keyid script now.
> I dropped the optional dst arg, since we don't use it.
>
> Thanks,
> Rusty.
> ===
> From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Subject: [PATCH] kbuild: sign the modules at install time
>
> Linus deleted the old code and put signing on the install command,
> I fixed it to extract the keyid and signer-name within sign-file
> and cleaned up that script now it always signs in-place.

Ugh. That was horribly broken, and sadly I didn't notice until several
pulls later (I tend to try to compile-test much more often, but do
boot-tests only a couple of times a day).

You clearly hadn't tested that patch at all, the resulting signature
was broken in two independent and totally different ways.

Tssk. I fixed it up, and now it works-for-me(tm), but some perl person
probably really should try to make that sign-file and x509keyid merge.
My fix made the thing even slower, doing two extra "wc -c" invocations
since it can't do "${#..}" expansion due to the locale problem.

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/