Re: [PATCH 1/2] mmc: core: bus.c: removed unnecessary NULL checkfor kfree(...)

From: Philip Rakity
Date: Fri Oct 19 2012 - 10:54:09 EST



On 19 Oct 2012, at 14:58, Sangho Yi <antiroot@xxxxxxxxx> wrote:

> kfree(NULL) is safe so I removed the if statements for NULL check.
>
> Signed-off-by: Sangho Yi <antiroot@xxxxxxxxx>
> ---
> drivers/mmc/core/bus.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
> index 9b68933..420cb67 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> @@ -225,8 +225,7 @@ static void mmc_release_card(struct device *dev)
>
> sdio_free_common_cis(card);
>
> - if (card->info)
> - kfree(card->info);
> + kfree(card->info);
>
> kfree(card);
> }
> --
> 1.7.9.5

Reviewed-by: Philip Rakity <prakity@xxxxxxxxxx>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/