Re: [PATCH 00/23] printk: refactoring

[Andrew Morton]

On Tue, 16 Oct 2012 23:06:04 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> Make printk a bit more readable.
> 
> Joe Perches (23):
>   printk: Move to separate directory for easier modification
>   printk: Add console_cmdline.h
>   printk: Move braille console support into separate braille.[ch] files
>   printk: Use pointer for console_cmdline indexing
>   printk: rename struct log to struct printk_log
>   printk: Rename log_buf and __LOG_BUF_LEN
>   printk: Rename log_first and log_next variables
>   printk: Rename log_<foo> variables and functions
>   printk: Rename enum log_flags to printk_log_flags
>   printk: Rename log_wait to printk_log_wait
>   printk: Rename logbuf_lock to printk_logbuf_lock
>   printk: Rename clear_seq and clear_idx variables
>   printk: Remove static from printk_ variables
>   printk: Rename LOG_ALIGN to PRINTK_LOG_ALIGN
>   printk: Add and use printk_log.h
>   printk: Add printk_log.c
>   printk: Make wait_queue_head_t printk_log_wait extern
>   printk: Rename and move 2 #defines to printk_log.h
>   printk: Move devkmsg bits to separate file
>   printk: Prefix print_time and msg_print_text with printk_
>   printk: Move functions printk_print_time and printk_msg_print_text
>   printk: Add printk_syslog.c and .h
>   printk: Move kmsg_dump functions to separate file

OK, nobody's allowed to change the printk code for two months.

>  drivers/accessibility/braille/braille_console.c |    9 +-
>  fs/proc/kmsg.c                                  |    4 +-
>  kernel/Makefile                                 |    3 +-
>  kernel/printk.c                                 | 2820 -----------------------
>  kernel/printk/Makefile                          |    6 +
>  kernel/printk/braille.c                         |   48 +
>  kernel/printk/braille.h                         |   48 +
>  kernel/printk/console_cmdline.h                 |   14 +
>  kernel/printk/devkmsg.c                         |  309 +++
>  kernel/printk/kmsg_dump.c                       |  328 +++
>  kernel/printk/printk.c                          | 1515 ++++++++++++
>  kernel/printk/printk_log.c                      |  263 +++
>  kernel/printk/printk_log.h                      |  123 +
>  kernel/printk/printk_syslog.c                   |  354 +++
>  kernel/printk/printk_syslog.h                   |   12 +

It wouldn't hurt to describe the design here a bit.  How was the code
partitioned and what is the role of each file?

That's reasonably obvious from the names, but some might wonder about
the difference between printk_log and printk_syslog and how that
division was decided upon.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/