Re: [PATCH 3/4] thp: introduce hugepage_vma_check()

From: Andrew Morton
Date: Thu Oct 18 2012 - 16:32:19 EST


On Thu, 18 Oct 2012 13:16:04 -0700 (PDT)
David Rientjes <rientjes@xxxxxxxxxx> wrote:

> On Thu, 18 Oct 2012, Bob Liu wrote:
>
> > Multi place do the same check.
> >
>
> This only succeeds in removing four lines and makes the code more
> difficult to follow

I like it. It takes a bunch of code sequences which may or may not be the
same and removes all doubt, while making the call sites clearer.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/