Re: [PATCH] dynamic_debug: Remove unnecessary __used

From: Jason Baron
Date: Thu Oct 18 2012 - 15:54:25 EST


On Thu, Oct 18, 2012 at 12:07:03PM -0700, Joe Perches wrote:
> The __used attribute prevents gcc from eliminating
> unnecessary, otherwise optimized away, metadata for
> debugging logging messages.
>
> Remove the __used attribute.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> include/linux/dynamic_debug.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
> index c18257b..6dd4787 100644
> --- a/include/linux/dynamic_debug.h
> +++ b/include/linux/dynamic_debug.h
> @@ -61,7 +61,7 @@ int __dynamic_netdev_dbg(struct _ddebug *descriptor,
> const char *fmt, ...);
>
> #define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
> - static struct _ddebug __used __aligned(8) \
> + static struct _ddebug __aligned(8) \
> __attribute__((section("__verbose"))) name = { \
> .modname = KBUILD_MODNAME, \
> .function = __func__, \
>
>

Greg, Pls pull this.

Acked-by: Jason Baron <jbaron@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/