Re: [PATCH 1/6] mmc: core: sdio_io.c: Fixed lines with > 80 chars

From: Joe Perches
Date: Thu Oct 18 2012 - 12:47:19 EST


On Fri, 2012-10-19 at 01:31 +0900, Sangho Yi wrote:
> I fixed lines over 80 characters per line.

If you really must do these things, please use
checkpatch.pl --strict for guidance on how to align
function arguments.

> diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c
[]
> @@ -664,7 +665,8 @@ void sdio_f0_writeb(struct sdio_func *func, unsigned char b, unsigned int addr,
>
> BUG_ON(!func);
>
> - if ((addr < 0xF0 || addr > 0xFF) && (!mmc_card_lenient_fn0(func->card))) {
> + if ((addr < 0xF0 || addr > 0xFF) &&
> + (!mmc_card_lenient_fn0(func->card))) {

ugly alignment and unnecessary parenthesis too.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/